[solved] kopano-server[]: setSyncStatus(): collision

tommi

Hi Felix,

version 8.7.80.27-0+22.1 solved it.

Greets Thomas

Han

Hello Felix,
after updae to 8.7.80.27 no errors setSyncStatus(): collision appaer,
but a lot of SQL errors like these:

Wed Oct 31 11:52:02 2018: [error  ] SQL [00000013] Failed: Duplicate entry '295398-26083-258' for key 'PRIMARY', Query Size: 343, Query: "INSERT INTO properties (hierarchyid,tag,type,properties.val_ulong,properties.val_string,properties.val_binary,properties.val_double,properties.val_longint,properties.val_hi,properties.val_lo) VALUES(295398,26083,258,null,null,';▒▒C▒▒▒Hi▒▒▒\0',null,null,null,null),(295398,26082,258,null,null,';▒▒C▒▒▒Hi▒▒▒\0',null,null,null,null)"
Wed Oct 31 11:52:02 2018: [error  ] KDatabase::I_Update() query failed: "Duplicate entry '295398-26083-258' for key 'PRIMARY'", query: INSERT INTO properties (hierarchyid,tag,type,properties.val_ulong,properties.val_string,properties.val_binary,properties.val_double,properties.val_longint,properties.val_hi,properties.val_lo) VALUES(295398,26083,258,null,null,';▒▒C▒▒▒Hi▒▒▒\0',null,null,null,null),(295398,26082,258,null,null,';▒▒C▒▒▒Hi▒▒▒\0',null,null,null,null)

I think the update made my system work worse than before.
So I will roll back to the last state.

Regards
Han

tommi

Hello,

Yes, unfortunately the same here. It seems that every incoming mail generates the error.
Maybe open a new thread for this.

Regards
Thomas

fbartels

@tommi said in [solved] kopano-server[]: setSyncStatus(): collision:

Yes, unfortunately the same here. It seems that every incoming mail generates the error

Issue should be resolved with the packages that have just finished uploading.

umgfoin

@fbartels said in [solved] kopano-server[]: setSyncStatus(): collision:

Issue should be resolved with the packages that have just finished uploading.

Hi Felix,
no, still present in KC-master 31.10.2018 15:49 CET.

This issue is unrelated to the topic of this thread.
The problem came with recent refactorings in commit 0f8c99a3891, where ECRESULT AddChange(BTSession * ... uses the new infrastructure for std::list<propVal> based batch property-inserts.

Whereas the formerly called

ECRESULT WriteProp(ECDatabase *lpDatabase, unsigned int ulObjId, unsigned int ulParentId, struct propVal *lpPropVal, bool replace = true);

defined default parameter replace = true implementing REPLACE-queries for property writes, the now used

ECRESULT InsertProps(ECDatabase *lpDatabase, unsigned int ulObjId, unsigned int ulParentId, std::list<propVal> &propList);

treats all property-modifications as INSERT-queries, which is inappropriate to update an existing property.

for (auto &i : propList) {
		WriteSingleProp(database, objId, parentId, &i, false, 0, query, false);
		WriteSingleProp(database, objId, parentId, &i, true, 0, colquery, false);
}

Forcing InsertProps to create REPLACE -queries fixes the issue, but might have other implications.

WriteSingleProp(database, objId, parentId, &i, false, 0, query, true);
WriteSingleProp(database, objId, parentId, &i, true, 0, colquery, true);

++umgfoin.

deHoeninger

@umgfoin
I’m running into the same issue. It looks like Jelle van der Waa already addressed this issue with Commit https://stash.kopano.io/users/jvanderwaa/repos/kopanocore/commits/9df8d2c16613450d9662d99e27a0fe4b204be091

But it don’t found its way into Master yet.

Best Jan

umgfoin

Hi Jan,
it was merged into master, yesterday - so probably 'be part of the next community-build.
++umgfoin.

deHoeninger

@umgfoin said in [solved] kopano-server[]: setSyncStatus(): collision:

it was merged into master, yesterday - so probably 'be part of the next community-build.

Your are right, my fault. Should already be part of last nightly build.

Best Jan