File Plugin: Add Attachment to Email is broken

kg

Hey,
in the latest version of the Files plugin, it’s not possible to add attachments to Emails anymore. I think I tracked it down to the fact that the files are not being downloaded from the Backend (in our case Owncloud/Nextcloud). It seems to have been caused by this commit: https://stash.kopano.io/projects/KWA/repos/files/diff/php/class.filesbrowsermodule.php?until=6d3d8898d734089dff72786050c2def86386cc6c

I think the missing of the get_file is causing the bug.

$initializedBackend->get_file($relRecId, $tmpname);

I tested the following fix and it works again for us:

$parts = explode('/', $file);
array_shift($parts);
$initializedBackend->get_file(implode('/', $parts), $tmpname);

Would be nice to have that working again. Thanks.

marty

Hi @kg I quickly checked this on master.
Works for me.
What versions of files + backends do you use?

kg

Hey,
thanks for looking into it. I just tried it with the latest version available here https://download.kopano.io/community/files:/ and it’s not working.

The versions reported in the Webapp are 2.1 for the Files plugin and 0.1 for the Owncloud Backend.

kg

I tried again with todays nightly and it’s fixed. Thanks.