Importinc an ical apointment is shown 1 Hr later

strippe96

@strippe96 Found the bug:

Pls. have a look to /usr/share/kopano-webapp/plugins/files/php/Files/Backend/Webdav/sabredav/vendor/sabre/vobject/lib/Sabre/VObject/Property/DateTime.php at line 246. If an Appointment without Timezone ( eg. “Z” -> DTSTART:20200227T155500 ) is passed to function setDateTime, the function assumed type “LOCAL” and does not take care of the local timezone. Inserting

$this->offsetSet(‘TZID’, $dt->getTimeZone()->getName());

just before the “break;” will sove this.

BR Thomas

marty

@strippe96

Line 246 does not exist in that file.

The extra hour is also added without having files plugin on the server.

strippe96

Sorry, my failure. Please add the line (No 76) “$this->offsetSet(‘TZID’, $dt->getTimeZone()->getName());” in “case self::LOCAL :” just before “break;”

public function setDateTime(\DateTime $dt, $dateType = self::LOCALTZ) {

    switch($dateType) {

        case self::LOCAL :
            $this->setValue($dt->format('Ymd\\THis'));
            $this->offsetUnset('VALUE');
            $this->offsetUnset('TZID');
            $this->offsetSet('VALUE','DATE-TIME');
            $this->offsetSet('TZID', $dt->getTimeZone()->getName());
            break;
        case self::UTC :
            $dt->setTimeZone(new \DateTimeZone('UTC'));
            $this->setValue($dt->format('Ymd\\THis\\Z'));
            $this->offsetUnset('VALUE');
            $this->offsetUnset('TZID');
            $this->offsetSet('VALUE','DATE-TIME');
            break;
        case self::LOCALTZ :
            $this->setValue($dt->format('Ymd\\THis'));
            $this->offsetUnset('VALUE');
            $this->offsetUnset('TZID');
            $this->offsetSet('VALUE','DATE-TIME');
            $this->offsetSet('TZID', $dt->getTimeZone()->getName());
            break;
        case self::DATE :
            $this->setValue($dt->format('Ymd'));
            $this->offsetUnset('VALUE');
            $this->offsetUnset('TZID');
            $this->offsetSet('VALUE','DATE');
            break;
        default :
            throw new \InvalidArgumentException('You must pass a valid dateType constant');

    }
    $this->dateTime = $dt;
    $this->dateType = $dateType;

}

Cheers, Thomas

marty

@strippe96

What makes you think this code is used while importing an ics?

strippe96

@marty Dear Marty,

when I´ll try to Import an ICS-file, where the DTSTART / DTEND Tags are noted without a timezone marker (e.g. “Z” at the End), the Appointment will be 1 hr later in the Calendar. This is fixed after applying this Change. All Appointments are shown at the correct time.

marty

@strippe96 Can you try to reproduce it without this plugin installed on the server
(I could, as stated before)

strippe96

@marty Sorry Marty, I´ll missunderstood you. Can you please explain, witch module and how to deinstall?
Thanks in Advance.

Thomas

marty

@strippe96
The code you modified is from an external module inside the files plugin.

Without the files plugin, the described behavior i.e. bug is also reproducible.
And a fix for WebApp in an external plugin is not a good idea.

strippe96

@marty Hey marty, after removing files, I´ve got the same result. 1 Hr in advance.

strippe96

@marty From my point of view, I´ll want to say, that this module is “fromoutside to webapp” but it´s local to the files module. This function seems to be used only if files (importing an appointment e.g.) is using it.
For me, it´s ok to change it here. Isn´t it?