Cannot create company public store due to wrong flags check in kopano-storeadm

[modelnine]

kopano-storeadm uses an invalid conditional to check whether a company public store is being created with -Pk:

} else if (opt_companyname != nullptr && !opt_copytopublic) {

on line 930 should rather be:

} else if (opt_companyname != nullptr && !opt_create_public) {

Currently,this means that the default createcompany.d script (which calls kopano-storeadm with -Pk) fails to create the company public folder and fails silently; the corresponding companies show as orphans without a store, too.

As the error is in kopano-storeadm (checked against head on github), there is currently no way to actually create company public stores. Please fix this. Thanks. :-)

[fbartels]

Hi @modelnine,

good catch. Would you be open to open a PR (on Github) with your desired change?

[jengelh]

internal ref: stash 2813.

[modelnine]

@jengelh from the comment, I gather that I don’t need to create a pull request anymore? ;-)